util/chunk: optimize (*ListInDisk).GetChunk and add a fast row container reader (#45130)
#45204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
4 tasks
ti-chi-bot
added
release-note-none
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
do-not-merge/release-note-label-needed
xhebox
approved these changes
Jul 10, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
added
the
cherry-pick-approved
wshwsh12
approved these changes
Jul 25, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
1 similar comment
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #45204 +/- ##
================================================
Coverage ? 73.6739%
================================================
Files ? 1081
Lines ? 346737
Branches ? 0
================================================
Hits ? 255455
Misses ? 74871
Partials ? 16411 |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #45130
What problem does this PR solve?
Issue Number: close #45125
Problem Summary:
The existing reading method of
RowContainer(GetChunk(...)) is not fast enough for dumping a lot of rows from disk (for thecursorFetchuse case).The existing
Iterator4RowContaineris even slower, as it allocates a new chunk for each row 🤦.This PR is extracted from #44730 (with a some refractor).
What is changed and how it works?
This PR pipelines the IO and CPU calculation, to make full use of the IO bandwidth. It should also help other features using
rowContainer, asGetChunkis now much faster.The performance of existing benchmark
BenchmarkListInDisk_GetChunkincreases from2877471ns/opto462864ns/opCheck List
Tests